fix: properly set the sky textures, only during the day#382
Merged
Conversation
JaXt0r
requested changes
Jun 18, 2026
| { | ||
| // all states that contain day sky layer dawn, evening and day 0 to 3 | ||
| if (state.Time < 0.35 || state.Time > 0.65) | ||
| if (!(state.Time < 0.35) || !(state.Time > 0.65)) // set new textures only for day states |
Contributor
There was a problem hiding this comment.
Is time really a value from 0...1? I thought it's an int from 0...23 or so? Can you please check? 0.65 is tough to read instead of e.g. 8am.
Contributor
There was a problem hiding this comment.
And yes, it was there before, but maybe you find a nicer solution now. 😁
Contributor
Author
There was a problem hiding this comment.
i want to handle this in a slightly bigger refactor, i don't like it either, this is just a quick fix for the modding weekend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sky textures for the day were set during the night
How to test
Set time to 23 and boot up